[SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in Java API documentation #16013

HyukjinKwon · 2016-11-25T17:40:59Z

What changes were proposed in this pull request?

This PR make sbt unidoc complete with Java 8.

This PR roughly includes several fixes as below:

Fix unrecognisable class and method links in javadoc by changing it from [[..]] to `...`

- * A column that will be computed based on the data in a [[DataFrame]].
+ * A column that will be computed based on the data in a `DataFrame`.

Fix throws annotations so that they are recognisable in javadoc

Fix URL links to <a href="http..."></a>.

- * [[http://en.wikipedia.org/wiki/Decision_tree_learning Decision tree]] model for regression.
+ * <a href="http://en.wikipedia.org/wiki/Decision_tree_learning">
+ * Decision tree (Wikipedia)</a> model for regression.

-   * @see http://en.wikipedia.org/wiki/Receiver_operating_characteristic
+   * @see <a href="http://en.wikipedia.org/wiki/Receiver_operating_characteristic">
+   * Receiver operating characteristic (Wikipedia)</a>

Fix < to > to
- greater than/greater than or equal to or less than/less than or equal to where applicable.
- Wrap it with {{{...}}} to print them in javadoc or use {@code ...} or {@literal ..}. Please refer [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in Java API documentation #16013 (comment)
Fix </p> complaint

How was this patch tested?

Manually tested by jekyll build with Java 7 and 8

java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)

java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

HyukjinKwon · 2016-11-25T17:42:01Z

cc @srowen, this PR finally resolves the issue and makes sbt unidoc working fine with Java 8! Let me try to double check and leave some comments tomorrow.

srowen · 2016-11-25T18:47:43Z

core/src/main/scala/org/apache/spark/SparkConf.scala

@@ -262,7 +262,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
  /**
   * Get a time parameter as seconds; throws a NoSuchElementException if it's not set. If no
   * suffix is provided then seconds are assumed.
-   * @throws NoSuchElementException
+   * @note Throws `NoSuchElementException`


Oh, I think this may be resolved if java.util.NoSuchElementException is imported, or if the fully qualified name is used here. I favor the latter. That would be better; does it work?

SparkQA · 2016-11-25T20:07:13Z

Test build #69169 has finished for PR 16013 at commit 3660317.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-11-25T20:16:16Z

Test build #69171 has finished for PR 16013 at commit 22bfb68.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-11-26T03:48:05Z

core/src/main/scala/org/apache/spark/Accumulator.scala

@@ -26,7 +26,7 @@ package org.apache.spark
 *
 * An accumulator is created from an initial value `v` by calling
 * [[SparkContext#accumulator SparkContext.accumulator]].
- * Tasks running on the cluster can then add to it using the [[Accumulable#+= +=]] operator.
+ * Tasks running on the cluster can then add to it using the `+=` operator.


I just decided to keep original format rather than trying to make this pretty.

The original was as below:

Scala

Java

After this PR it still prints the same.

Scala

Java

HyukjinKwon · 2016-11-26T03:49:15Z

core/src/main/scala/org/apache/spark/SparkConf.scala

@@ -262,8 +262,9 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
  /**
   * Get a time parameter as seconds; throws a NoSuchElementException if it's not set. If no
   * suffix is provided then seconds are assumed.
-   * @throws NoSuchElementException
+   * @throws java.util.NoSuchElementException


This is interesting. Using @throws NoSuchElementException complains as below:

[error] location: class VectorIndexerModel [error] .../java/org/apache/spark/SparkConf.java:226: error: reference not found [error] * @throws NoSuchElementException [error] ^

HyukjinKwon · 2016-11-26T03:50:31Z

core/src/main/scala/org/apache/spark/SparkContext.scala

@@ -2063,6 +2063,7 @@ class SparkContext(config: SparkConf) extends Logging {
   * @param jobId the job ID to cancel
   * @throws InterruptedException if the cancel message cannot be sent


This is interesting too. This does not throws an error in javadoc8 unlike https://github.com/apache/spark/pull/16013/files#r89664921

It seems fine

Scala

Java

HyukjinKwon · 2016-11-26T04:01:29Z

core/src/main/scala/org/apache/spark/SparkConf.scala

   */
+  @throws(classOf[NoSuchElementException])


Before

Scala

Java

After

Scala

Java

HyukjinKwon · 2016-11-26T04:49:22Z

core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala

@@ -155,7 +155,7 @@ class DoubleRDDFunctions(self: RDD[Double]) extends Logging with Serializable {
   * to the right except for the last which is closed
   *  e.g. for the array
   *  [1, 10, 20, 50] the buckets are [1, 10) [10, 20) [20, 50]
-   *  e.g 1<=x<10 , 10<=x<20, 20<=x<=50
+   *  e.g 1&lt;=x&lt;10 , 10&lt;=x&lt;20, 20&lt;=x&lt;=50


This originally gives an error as below

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:73: error: malformed HTML [error] * e.g 1<=x<10, 10<=x<20, 20<=x<=50 [error] ^ [error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:73: error: malformed HTML [error] * e.g 1<=x<10, 10<=x<20, 20<=x<=50 [error] ^ [error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:73: error: malformed HTML [error] * e.g 1<=x<10, 10<=x<20, 20<=x<=50 [error] ^ ...

However, after fixing it as above,

This is being printed as they are in javadoc (not in scaladoc)

It seems we should find another approach to deal with this. It seems &#60 and &#62 also do not work. It seems & is always converted into &.

In generated javadoc,

these throw errors

<
<code>.. < .. </code>
<blockquote> ... < .. </blockquote>
`... < ..`
{{{... < ..}}}

as below:

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:71: error: malformed HTML [error] * <

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:72: error: malformed HTML [error] * <code>.. < .. </code>

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:73: error: malformed HTML [error] * <blockquote> ... < .. </blockquote>

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:74: error: malformed HTML [error] * <code>... < ..</code>

[error] .../java/org/apache/spark/rdd/DoubleRDDFunctions.java:75: error: malformed HTML [error] * <pre><code>... < ..</code></pre>

These do not print < but <.

<
<code>.. < .. </code>
<blockquote> ... < .. </blockquote>
`... < ..`
{{{... < ..}}}

as below:

The below one is fine

{{{ 1<=x<10 , 10<=x<20, 20<=x<=50 }}}

but newlines are inserted as below:

note to myself, It seems inlined tags such as

{@code ... < ...}

and

{@literal >}

work also okay for both but they are valid ones for javadoc. For scaladoc, they are dealt with monospace text (like `<` or `... < ...`). As genjavadoc seems not replacing it, it seems they work apparently okay. I guess we should avoid those though.

SparkQA · 2016-11-26T05:44:47Z

Test build #69179 has finished for PR 16013 at commit 73fcd35.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-11-26T18:05:14Z

core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala

@@ -103,7 +103,8 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val classTag: ClassTag[T])
   * @param withReplacement can elements be sampled multiple times (replaced when sampled out)
   * @param fraction expected size of the sample as a fraction of this RDD's size
   *  without replacement: probability that each element is chosen; fraction must be [0, 1]
-   *  with replacement: expected number of times each element is chosen; fraction must be &gt;= 0
+   *  with replacement: expected number of times each element is chosen; fraction must be greater
+   *  than or equal to 0


I can work around this to {@code >=} if this looks too verbose.

Prose is fine too, but, was this an error? is the point that the escape itself gets escaped? I might have missed this is your various comments.

Oh, yes. Exactly. It was not an error but it was printed as they are (> as &gt;). I had a hard time to figure this out in #16013 (comment)

I haven't looked into this super deeper as the output is incorrect anyway but I suspect this replacement in genjavadoc.

In short, the only workarounds to print them I found were inlined tags such as {@code ...} and {{{...}}} block with newlines.

HyukjinKwon · 2016-11-26T18:07:32Z

core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala

   *  e.g. for the array
   *  [1, 10, 20, 50] the buckets are [1, 10) [10, 20) [20, 50]
   *  e.g 1<=x<10 , 10<=x<20, 20<=x<=50
+   * }}}


Scala

Java

Why put the whole section as code? it's just the portion with several inequalities. Can those be back-tick-escaped? Or is the point that the back-ticks don't work? does {@code ...} work with < / > ?

BTW, very minor, but the second "e.g" misses a period. "e.g." isn't really great either. You could expand the first to "For example" and the second to "that is", which was really what was meant.

I just wanted to avoid to use inlined tags simply because my IDE shows some warnings..

This seems a valid javadoc markdown but it seems any inlined tags are treated as backticts in scaladoc.

(I am sorry for messing around with many comments but this is also related with #16013 (comment))

I will try to treat the comments below too but let me maybe try to reduce the usages of the inlined tags where possible.

{@code} is valid in Javadoc; is it saying basically any {@foo } syntax is treated as back-tick-quoted by scaladoc? as it happens that's fine here right? can you just disable the warning in your IDE? If it produces the correct output then that's going to be a nicer rendering than breaking out new code blocks.

Yeap. I tested some cases with it (If I remember correctly) and it seems any {@foo } syntax is treated as back-tick-quoted by scaladoc (I will test more in case and will be back here to fix the comment if I was wrong). Sure, sounds great!

HyukjinKwon · 2016-11-26T18:12:28Z

core/src/main/scala/org/apache/spark/rdd/RDD.scala

+   *                        {{{
+   *                        def printRDDElement(record:(String, Seq[String]), f:String=>Unit) =
+   *                          for (e <- record._2) {f(e)}
+   *                        }}}


Scala

Java

HyukjinKwon · 2016-11-26T18:18:27Z

core/src/main/scala/org/apache/spark/scheduler/InputFormatInfo.scala

@@ -162,6 +163,7 @@ object InputFormatInfo {
    go to (a) until required nodes are allocated.

    If a node 'dies', follow same procedure.
+    }}}


Java

Scaladoc not found.

If this is just to get around the ->, I would instead change that to "to" and leave this. Or, if you like, make it an HTML ordered list

HyukjinKwon · 2016-11-26T18:19:54Z

core/src/main/scala/org/apache/spark/ui/UIUtils.scala

+   * <script>
+   * }}}
+   *
+   * will cause in the whole description to be treated as plain text.


Java

Scaladoc not found

HyukjinKwon · 2016-11-26T18:22:47Z

core/src/main/scala/org/apache/spark/util/Utils.scala

+   * according to semantics where
+   *
+   * {{{
+   * NaN == NaN and NaN > any non-NaN double


Java

Scaladoc not found

Just change this to "is greater than". It's not really code we're describing here but semantics of numeric ordering

SparkQA · 2016-11-28T07:59:56Z

Test build #69219 has finished for PR 16013 at commit 29d65cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

srowen

Just a handful of additional changes, looking good

srowen · 2016-11-28T09:11:21Z

core/src/main/scala/org/apache/spark/SparkContext.scala

@@ -2063,6 +2063,7 @@ class SparkContext(config: SparkConf) extends Logging {
   * @param jobId the job ID to cancel
   * @throws InterruptedException if the cancel message cannot be sent
   */
+  @throws(classOf[InterruptedException])


I think these need to be reverted too; we don't want to introduce checked exceptions

Oh, actually this complains as below:

[error] .../java/org/apache/spark/SparkContext.java:1150: error: exception not thrown: java.lang.InterruptedException [error] * @throws InterruptedException if the cancel message cannot be sent [error] ^

Let me move this to @note.

srowen · 2016-11-28T09:19:37Z

mllib/src/main/scala/org/apache/spark/mllib/rdd/SlidingRDD.scala

@@ -42,8 +42,8 @@ class SlidingRDDPartition[T](val idx: Int, val prev: Partition, val tail: Seq[T]
 * @param windowSize the window size, must be greater than 1
 * @param step step size for windows
 *
- * @see [[org.apache.spark.mllib.rdd.RDDFunctions.sliding(Int, Int)*]]
- * @see [[scala.collection.IterableLike.sliding(Int, Int)*]]
+ * @see `org.apache.spark.mllib.rdd.RDDFunctions.sliding(Int, Int)*`


Is the trailing * intentional or a typo? no big deal anyway

Let me please leave as they are. I am worried of getting blamed in the future. I will keep in mind that I should leave a comment for this when someone tries to change something around this.

Heh, OK. I don't think it has any meaning in a hyperlink or javadoc syntax, and this isn't either one anyway, but it's OK to leave it.

Thank you for bearing with me.

srowen · 2016-11-28T09:20:01Z

mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/BoostingStrategy.scala

 *                      of validation error is compared to relative tolerance which is
 *                      validationTol * (current loss on the validation set).
- *                      If the current loss on the validation set is <= 0.01, the diff
- *                      of validation error is compared to absolute tolerance which is
+ *                      If the current loss on the validation set is less than or euqal to 0.01,


typo: euqal -> equal

SparkQA · 2016-11-28T12:19:34Z

Test build #69241 has finished for PR 16013 at commit 7d44dc5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2016-11-28T12:22:11Z

core/src/main/scala/org/apache/spark/SparkContext.scala

@@ -2061,9 +2061,8 @@ class SparkContext(config: SparkConf) extends Logging {
   * Cancel a given job if it's scheduled or running.
   *
   * @param jobId the job ID to cancel
-   * @throws InterruptedException if the cancel message cannot be sent
+   * @note Throws `InterruptedException` if the cancel message cannot be sent


Hm, InterruptedException is in java.lang so I am surprised it isn't found. Does it help if you write @throws java.lang.InterruptedException? that's better if it works

Sure, I will try!

Hm.. interesting. I haven't looked into this deeper but it seems it fails anyway.

[error] .../java/org/apache/spark/SparkContext.java:1150: error: exception not thrown: java.lang.InterruptedException [error] * @throws java.lang.InterruptedException if the cancel message cannot be sent [error] ^

Hm, so it's just complaining that it's documented as a checked exception but can't be thrown according to the byte code. It has a point there, but I am also kind of surprised it's an error. OK Leave it the way you have it as it seems like it's the only way that works.

srowen

Great, looks like this gets us to compatibility with javadoc 8 and we should get this in 2.1.

HyukjinKwon · 2016-11-28T13:53:22Z

Thank you so much @srowen.

…ibility in Java API documentation ## What changes were proposed in this pull request? This PR make `sbt unidoc` complete with Java 8. This PR roughly includes several fixes as below: - Fix unrecognisable class and method links in javadoc by changing it from `[[..]]` to `` `...` `` ```diff - * A column that will be computed based on the data in a [[DataFrame]]. + * A column that will be computed based on the data in a `DataFrame`. ``` - Fix throws annotations so that they are recognisable in javadoc - Fix URL links to `<a href="http..."></a>`. ```diff - * [[http://en.wikipedia.org/wiki/Decision_tree_learning Decision tree]] model for regression. + * <a href="http://en.wikipedia.org/wiki/Decision_tree_learning"> + * Decision tree (Wikipedia)</a> model for regression. ``` ```diff - * see http://en.wikipedia.org/wiki/Receiver_operating_characteristic + * see <a href="http://en.wikipedia.org/wiki/Receiver_operating_characteristic"> + * Receiver operating characteristic (Wikipedia)</a> ``` - Fix < to > to - `greater than`/`greater than or equal to` or `less than`/`less than or equal to` where applicable. - Wrap it with `{{{...}}}` to print them in javadoc or use `{code ...}` or `{literal ..}`. Please refer #16013 (comment) - Fix `</p>` complaint ## How was this patch tested? Manually tested by `jekyll build` with Java 7 and 8 ``` java version "1.7.0_80" Java(TM) SE Runtime Environment (build 1.7.0_80-b15) Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode) ``` ``` java version "1.8.0_45" Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) ``` Author: hyukjinkwon <[email protected]> Closes #16013 from HyukjinKwon/SPARK-3359-errors-more. (cherry picked from commit f830bb9) Signed-off-by: Sean Owen <[email protected]>

srowen · 2016-11-29T09:42:16Z

Merged to master/2.1

…ibility in Java API documentation ## What changes were proposed in this pull request? This PR make `sbt unidoc` complete with Java 8. This PR roughly includes several fixes as below: - Fix unrecognisable class and method links in javadoc by changing it from `[[..]]` to `` `...` `` ```diff - * A column that will be computed based on the data in a [[DataFrame]]. + * A column that will be computed based on the data in a `DataFrame`. ``` - Fix throws annotations so that they are recognisable in javadoc - Fix URL links to `<a href="http..."></a>`. ```diff - * [[http://en.wikipedia.org/wiki/Decision_tree_learning Decision tree]] model for regression. + * <a href="http://en.wikipedia.org/wiki/Decision_tree_learning"> + * Decision tree (Wikipedia)</a> model for regression. ``` ```diff - * see http://en.wikipedia.org/wiki/Receiver_operating_characteristic + * see <a href="http://en.wikipedia.org/wiki/Receiver_operating_characteristic"> + * Receiver operating characteristic (Wikipedia)</a> ``` - Fix < to > to - `greater than`/`greater than or equal to` or `less than`/`less than or equal to` where applicable. - Wrap it with `{{{...}}}` to print them in javadoc or use `{code ...}` or `{literal ..}`. Please refer apache#16013 (comment) - Fix `</p>` complaint ## How was this patch tested? Manually tested by `jekyll build` with Java 7 and 8 ``` java version "1.7.0_80" Java(TM) SE Runtime Environment (build 1.7.0_80-b15) Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode) ``` ``` java version "1.8.0_45" Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) ``` Author: hyukjinkwon <[email protected]> Closes apache#16013 from HyukjinKwon/SPARK-3359-errors-more.

## What changes were proposed in this pull request? This PR proposes to run Spark unidoc to test Javadoc 8 build as Javadoc 8 is easily re-breakable. There are several problems with it: - It introduces little extra bit of time to run the tests. In my case, it took 1.5 mins more (`Elapsed :[94.8746569157]`). How it was tested is described in "How was this patch tested?". - > One problem that I noticed was that Unidoc appeared to be processing test sources: if we can find a way to exclude those from being processed in the first place then that might significantly speed things up. (see joshrosen's [comment](https://issues.apache.org/jira/browse/SPARK-18692?focusedCommentId=15947627&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15947627)) To complete this automated build, It also suggests to fix existing Javadoc breaks / ones introduced by test codes as described above. There fixes are similar instances that previously fixed. Please refer #15999 and #16013 Note that this only fixes **errors** not **warnings**. Please see my observation #17389 (comment) for spurious errors by warnings. ## How was this patch tested? Manually via `jekyll build` for building tests. Also, tested via running `./dev/run-tests`. This was tested via manually adding `time.time()` as below: ```diff profiles_and_goals = build_profiles + sbt_goals print("[info] Building Spark unidoc (w/Hive 1.2.1) using SBT with these arguments: ", " ".join(profiles_and_goals)) + import time + st = time.time() exec_sbt(profiles_and_goals) + print("Elapsed :[%s]" % str(time.time() - st)) ``` produces ``` ... ======================================================================== Building Unidoc API Documentation ======================================================================== ... [info] Main Java API documentation successful. ... Elapsed :[94.8746569157] ... Author: hyukjinkwon <[email protected]> Closes #17477 from HyukjinKwon/SPARK-18692.

HyukjinKwon added 8 commits November 25, 2016 23:39

Fix errors (first round)

aa2dcb8

Fix errors (second round)

aa5acbb

Fix errors (third round)

ff17c3a

Fix the linelength style in KafkaUtils.scala

1593545

Fix errors (fourth round)

558d5e3

Fix errors (last round)

9a9d0cd

Fix more errors

842a738

Make markdown pretty for some links

3660317

HyukjinKwon changed the title ~~[WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in API Java documentation~~ [WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in Java API documentation Nov 25, 2016

Keep original style without new indentations

22bfb68

srowen reviewed Nov 25, 2016

View reviewed changes

Use throws annotation

73fcd35

HyukjinKwon commented Nov 26, 2016

View reviewed changes

HyukjinKwon added 2 commits November 27, 2016 01:58

Print < and > properly within this PR

246bef3

Fix other existing ones for < and >

a2a2011

HyukjinKwon commented Nov 26, 2016

View reviewed changes

Make sql parameter pretty in JdbcRDD

ee3b96b

HyukjinKwon commented Nov 26, 2016

View reviewed changes

HyukjinKwon mentioned this pull request Nov 28, 2016

[SPARK-18555][SQL]DataFrameNaFunctions.fill miss up original values in long integers #15994

Closed

srowen requested changes Nov 28, 2016

View reviewed changes

Fix a typo and remove chekced exception annotation

7d44dc5

srowen reviewed Nov 28, 2016

View reviewed changes

srowen approved these changes Nov 28, 2016

View reviewed changes

HyukjinKwon mentioned this pull request Nov 29, 2016

[SPARK-18615][DOCS] Switch to multi-line doc to avoid a genjavadoc bug for backticks #16050

Closed

asfgit closed this in f830bb9 Nov 29, 2016

HyukjinKwon mentioned this pull request Dec 2, 2016

[SPARK-18592][ML] Move DT/RF/GBT Param setter methods to subclasses #16017

Closed

HyukjinKwon mentioned this pull request Dec 14, 2016

[SPARK-18834][SS] Expose event time stats through StreamingQueryProgress #16258

Closed

gatorsmile mentioned this pull request Feb 2, 2017

[SPARK-18120 ][SQL] Call QueryExecutionListener callback methods for … #16664

Closed

HyukjinKwon mentioned this pull request Mar 30, 2017

[SPARK-18692][BUILD][DOCS] Test Java 8 unidoc build on Jenkins #17477

Closed

This was referenced Apr 21, 2017

[SPARK-15699] [ML] Implement a Chi-Squared test statistic option for measuring split quality #13440

Closed

[SPARK-17443][SPARK-11035] Stop Spark Application if launcher goes down and use reflection #15009

Closed

HyukjinKwon mentioned this pull request Apr 28, 2017

[MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (and typo hunting) #17801

Closed

HyukjinKwon mentioned this pull request May 19, 2017

[SPARK-20801] Record accurate size of blocks in MapStatus when it's above threshold. #18031

Closed

HyukjinKwon mentioned this pull request Jun 26, 2017

[SPARK-21210][DOC][ML] Javadoc 8 fixes for ML shared param traits #18420

Closed

HyukjinKwon deleted the SPARK-3359-errors-more branch January 2, 2018 03:39

		@@ -2063,6 +2063,7 @@ class SparkContext(config: SparkConf) extends Logging {
		* @param jobId the job ID to cancel
		* @throws InterruptedException if the cancel message cannot be sent

[SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in Java API documentation #16013

[SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc compatibility in Java API documentation #16013

Conversation

HyukjinKwon commented Nov 25, 2016 • edited Loading

What changes were proposed in this pull request?

How was this patch tested?

HyukjinKwon commented Nov 25, 2016 • edited Loading

Choose a reason for hiding this comment

SparkQA commented Nov 25, 2016

SparkQA commented Nov 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HyukjinKwon Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HyukjinKwon Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

HyukjinKwon Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

HyukjinKwon Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

SparkQA commented Nov 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HyukjinKwon Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparkQA commented Nov 28, 2016

srowen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SparkQA commented Nov 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srowen left a comment

Choose a reason for hiding this comment

HyukjinKwon commented Nov 28, 2016

srowen commented Nov 29, 2016

HyukjinKwon commented Nov 25, 2016 •

edited

Loading

HyukjinKwon commented Nov 25, 2016 •

edited

Loading

HyukjinKwon Nov 26, 2016 •

edited

Loading

HyukjinKwon Nov 26, 2016 •

edited

Loading

HyukjinKwon Nov 26, 2016 •

edited

Loading

HyukjinKwon Nov 26, 2016 •

edited

Loading

HyukjinKwon Nov 26, 2016 •

edited

Loading